remove the default replicas from validation#538
Merged
Conversation
Collaborator
Author
|
@travisn PTAL all the cases should work , the only issue was with default value in validation |
Removing the default replica count from the CRD to ensure that we can still allow the user to deploy single controller plugin deployment on the single node cluster. fixes: ceph#532 Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Member
|
LGTM, agreed that removing the default crd value is expected to fix the reported issue, thanks! |
Collaborator
Author
|
@Mergifyio backport release-1.0 |
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the default replica count from the CRD to ensure that we can still allow the user to deploy single controller plugin deployment on the single node cluster.
fixes: #532